fix: preserve original indentation character in /improve suggestions#2429
Open
Oxygen56 wants to merge 1 commit into
Open
fix: preserve original indentation character in /improve suggestions#2429Oxygen56 wants to merge 1 commit into
Oxygen56 wants to merge 1 commit into
Conversation
The dedent_code method only adjusted indentation when delta_spaces > 0 and never normalized the indentation character. This caused /improve to replace tabs with spaces in Go, Makefile, and other tab-indented codebases. Changes: - Handle delta_spaces < 0 case with dedent (not just > 0) - Normalize all suggestion lines to use the original file's indentation character (tab or space), auto-detected from the existing code Fixes The-PR-Agent#1858 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #1858 —
/improvereplaces tabs with spaces in tab-indented codebases (Go, Makefile, etc.)Root Cause
The
dedent_codemethod inpr_code_suggestions.pyonly adjusted indentation whendelta_spaces > 0and never normalized the suggestion indentation character to match the original file.Fix
delta_spaces < 0(suggested code has more indent than original) withtextwrap.dedentBefore
After