docs: use shell-portable env var names in install examples#2439
Open
IsmaelMartinez wants to merge 1 commit into
Open
docs: use shell-portable env var names in install examples#2439IsmaelMartinez wants to merge 1 commit into
IsmaelMartinez wants to merge 1 commit into
Conversation
Most shells cannot export a variable whose name contains a dot, so the GITHUB.BASE_URL / OPENAI.KEY style examples in the install docs broke when copied into a shell or a GitHub Actions env: block. Switch the examples to the double-underscore form (GITHUB__BASE_URL), which Dynaconf accepts identically and which the .env example already uses. Fixes The-PR-Agent#2310. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary by Qodo
Docs: use shell-portable double-underscore env var names in install examples
📝 Documentation🕐 Less than 10 minutesWalkthroughs
User Description
What
The install docs document env vars in the dotted form (
GITHUB.BASE_URL,OPENAI.KEY, ...). Dynaconf accepts both the dotted and double-underscore forms, but most shells can'texporta name containing a dot, and a GitHub Actionsenv:block with a dotted key is similarly problematic, so users copying these examples hit failures (#2310).Fix
Switch the example commands in
installation/locally.md(thedocker -eexamples) andinstallation/github.md(the GitHub-enterpriseenv:block) to the equivalent double-underscore form (GITHUB__BASE_URL), which works everywhere and which the existing.envexample andhelp_docs.mdalready use. The convention note that documents both forms is left intact, since both remain valid at the config layer.Fixes #2310.
AI Description
Diagram
graph TD U(["User"]) --> D["Installation docs"] --> R(["Docker run / GitHub Action"]) --> E{{"Environment variables"}} --> A["PR-Agent"] subgraph Legend direction LR _user(["Actor"]) ~~~ _step["Step/Component"] ~~~ _cfg{{"Config"}} endHigh-Level Assessment
The chosen approach is optimal: standardize docs examples on the double-underscore form that works in shells and GitHub Actions while remaining equivalent in Dynaconf. Considered alternatives (keeping dotted examples with warnings, or mixing both forms inline) add confusion and still lead to copy/paste failures.
File Changes
Documentation (2)