fix(engine): prevent core tool request redirects - #664
Merged
Merged
Conversation
thedancingdeveloper
force-pushed
the
fix/core-tools-redirects
branch
from
September 10, 2026 04:26
141e2ff to
eb3c8a3
Compare
thedancingdeveloper
force-pushed
the
fix/core-tools-redirects
branch
from
September 10, 2026 05:31
eb3c8a3 to
5d7065d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Harden the assistant's Vogt core MCP client against SSRF-style destination changes by validating the configured core URL and disabling HTTP redirects.
Why
The CodeQL
rust/request-forgeryfinding identified that a core response could redirect requests to an unintended destination. Invalid or credential-bearing core URLs are now rejected, and redirect responses remain failures.Part of #662 — fixes the
rust/request-forgeryfinding only; the remaining code-scanning/secret-scanning backlog stays open on #662.Verification
cargo fmt --all --manifest-path engine/Cargo.toml -- --checkcargo clippy --manifest-path engine/Cargo.toml --workspace --all-targets -- -D warningscargo test --manifest-path engine/Cargo.toml --workspaceuv run python scripts/check_docs.pyThe first engine test run required the PWA bundle; after
pnpm install --frozen-lockfile && pnpm build, the complete workspace suite passed.Docs
docs/ENGINE.mdupdated