Skip to content

[PORT] Newer Mindshield Sprites From Funky - #145

Open
NotMox wants to merge 6 commits into
TheDenSS14:masterfrom
NotMox:mindshieldiconchange
Open

[PORT] Newer Mindshield Sprites From Funky#145
NotMox wants to merge 6 commits into
TheDenSS14:masterfrom
NotMox:mindshieldiconchange

Conversation

@NotMox

@NotMox NotMox commented Aug 10, 2026

Copy link
Copy Markdown

About the PR

I FUCKED UP MY LAST PR, THIS ONE SHOULD BE FINE I HOPE CROSSING MY FINGERS AWHFDKJBHJKB
ported newer and better looking mindshield sprites
could not find any attribution or copyright information in the original PR

Why / Balance

wanted to dip my feat and start learning how to contribute and make PRs
(sprites also just look dramatically better)

Technical details

quick .json editing and sprite replacement
partial port of funky-station/funky-station#1231

Media

MindshieldPR-ezgif com-video-to-gif-converter

Requirements

  • I have read and am following the Macrocosm Pull Request Conventions.
  • I have tested this pull request and written instructions on how to test it.
  • I have added media to this PR or it does not require an in-game showcase.

Licensing

  • All code in this pull request can be licensed to MIT.
  • (OPTIONAL) I give permission to seeing this feature upstreamed to Macrocosm in the future.

Breaking changes

Not applicable, i just changed two files

Changelog

🆑 tweak: Ported Mindshield HUD sprites from Funky

<!-- Guidelines: https://docs.macrocosm.cool/docs/intro -->

## About the PR
ported newer and better looking mindshield sprites

## Why / Balance
wanted to dip my feat and start learning how to contribute and make PRs
(sprites also just look dramatically better)

## Technical details
quick .json editing and sprite replacement
partial port of funky-station/funky-station#1231
## Media
<!-- Attach media if the PR makes in-game changes (clothing, items, features, etc). -->

## Requirements
<!-- Confirm the following by placing an X in the brackets without spaces inside (for example: [X] ): -->
- [X] I have read and am following the Macrocosm [Pull Request Conventions](https://docs.macrocosm.cool/docs/Conventions/pull-requests/).
- [X] I have tested this pull request and written instructions on how to test it.
- [X] I have added media to this PR or it does not require an in-game showcase.
<!-- You should understand that not following the above may get your PR closed at maintainer’s discretion -->

### Licensing
<!--
    This is REQUIRED for any code submitted to The Den 2 repository.
    If this is a port, make sure to check the original repository's license!

    This code can be licensed to MIT if:
    1. You wrote it yourself, and you agree it can be MIT-licensed.
    2. The original pull request originates from an MIT-licensed codebase, such as Wizard's Den.
    3. The original code author submitted the code to a non-MIT (e.g. AGPLv3) codebase, but
       has given explicit permission to have their code re-licensed.

    If your code does not fit these cases, it probably can't be accepted!
    If you need help getting MIT licensing, please ask for help in our development channels.
-->
- [X] All code in this pull request can be licensed to MIT.

<!--
    Macrocosm is The Den 2's upstream repository. We may port features to Macrocosm if other
    servers that share the Macrocosm upstream are interested in the feature.
-->
- [X] (OPTIONAL) I give permission to seeing this feature upstreamed to Macrocosm in the future.

## Breaking changes
none, it is just a sprite change

## Changelog
<!-- Add a Changelog entry to make players aware of new features or changes that could affect gameplay.
Make sure to read the guidelines and take this Changelog template out of the comment block in order for it to show up.
Changelog must have a 🆑 symbol, so the bot recognizes the changes and adds them to the game's changelog.
The name that appears on the changelog will be your GitHub username by default. If you wish for a different name to appear, format the symbol like so:
🆑 My Name -->
🆑
- tweak: Changed Mindshield icons to the ones funky uses
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

RSI Diff Bot; head commit 59a0acd merging into 37a0a19
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Funky/Interface/Misc/job_icons.rsi

State Old New Status
MindShield Added

Edit: diff updated after 59a0acd

@sleepyyapril sleepyyapril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't replace upstream files and without credit, put it under a new file in the _Funky namespace with proper credit

you'll find the place to change it here at here

@sleepyyapril sleepyyapril added this needs direction review we gotta get the owners headmins and headmaints on this S: Awaiting Changes you gotta update it and removed S: Needs Review S: Untriaged labels Aug 12, 2026
@github-actions github-actions Bot added size/S and removed size/XS labels Aug 13, 2026
@NotMox
NotMox requested a review from sleepyyapril August 13, 2026 22:09
@github-actions github-actions Bot added S: Needs Review and removed S: Awaiting Changes you gotta update it labels Aug 13, 2026
@NotMox

NotMox commented Aug 13, 2026

Copy link
Copy Markdown
Author

Should now be compliant with what was requested, reverted the changes to upstream files and made a folder for funky
Tested in-game and everything should work just fine
Let me know if anything else needs fixing

Comment thread Resources/Prototypes/StatusIcon/security.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants