Player Requests by sleepyyapril · Pull Request #18 · TheDenSS14/TheDenTwo

sleepyyapril · 2025-11-04T16:48:43Z

The purpose of this system is to allow for various different types of "requests," whether that be offering or some other thing we think of in the future. For the most part, I tried to keep it open-ended and in shared for prediction purposes.

Another separate system would, theoretically, call StartRequest and handle the actual thing itself, so consider it more of an API than anything.

portfiend

valid test fail

portfiend

write a technical description of what's going on here blease

sleepyyapril · 2026-02-26T18:20:29Z

write a technical description of what's going on here blease

i need to document it more too ill get to it tho

MajorMoth · 2026-05-24T17:11:41Z

is it fine if I turn this into a draft?

* ants * oops forgot to make it not roundstart * flavor folly (get it like flavor foley like the vocaloid producer group but like a flavor folly like a mistake get it? because its a flavor mistake? flavor yaml linter fail?) * remove commented out components * TooShortForUIComponent * this is all alex's fault * remove sexy ant * add ants to the guidebook (commented out) * Update Resources/Prototypes/_MACRO/Species/ant.yml Co-authored-by: Kip <32859367+kipdotnet@users.noreply.github.com> * Update Resources/ServerInfo/_MACRO/Guidebook/Mobs/Species.xml Co-authored-by: Kip <32859367+kipdotnet@users.noreply.github.com> * fix * Update Resources/ServerInfo/_MACRO/Guidebook/Mobs/Species.xml Co-authored-by: Kip <32859367+kipdotnet@users.noreply.github.com> * Update Resources/ServerInfo/_MACRO/Guidebook/Mobs/Species.xml Co-authored-by: Kip <32859367+kipdotnet@users.noreply.github.com> * Update Resources/ServerInfo/_MACRO/Guidebook/Mobs/Species.xml Co-authored-by: Kip <32859367+kipdotnet@users.noreply.github.com> * i hate xml * also remove buxom ant * Add Salubrious and Powdered Ant --------- Co-authored-by: Kip <32859367+kipdotnet@users.noreply.github.com>

* Updated Cargo Integration Tests * usings * revert NoCargoOrderArbitrage * unneeded ; * . * review requests * review requests v2

* Update README.md with new links. (#2) * Update README.md with new links. * Update README.md with Princess-Cheeseballs' provided links. Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> * Removed an extra space. Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> * Update actions_changelog_rss.py with the new domain. * Update stylesheet.xsl * Update SECURITY.md --------- Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> * fix (#14) * Switch RT submodule to new repo (#19) * Remove toggle action from winter coat (#24) * i think i got them all * minor cleanup * init (#13) * Bugfix: Moproach/spider solution regeneration (#41) * moproach/spider solutions with recharge * mop mop mop roach * more straightforward moproach solution inheritance * Adds temperature protection to scarves (#47) * Adds temperature protection to scarves * YAML conventions say specific stuff is better at the bottom * Remove scream action, replace with emote action (#55) * no mroe screaming * if your angry and you know it scream with action grant! *clap clap* * emote action is more generic now * use flag instead * Revert "if your angry and you know it scream with action grant! *clap clap*" This reverts commit 7c40ee48 * screaming im screaming im screaming * reversed oops * Fix handheld grinders (#50) * fix * TEST!!!!!!!!!! * comment * what * im so silly * explosion!!!!! * i hate tests * those can be asserts too * i hate tests * Replace all uses of System.Random with IRobustRandom, resolve all System.Random warnings. (#32) * Remove all uses of System.Random * Use IRobustRandom in BinomialNumberSelector.Get * Remove remaining ToolRefinableSystem S.Random inst * Arcade sprite fixes & metadata cleanup (#40) * arcade sprite & metadata cleanup * 4 space meta.json * Bring cargo order menu to the front when selecting a new item * Bugfix: Remove infinite board dupe in television/telescreen construction graphs. (#42) * Fix telescreen/wallmount TV dupe * fix tagged icons * Initial commit (#3) * Fix blankline after games rules (#77) Annoyed me. * Fix illegible FileNotFoundError occurrences when git isn't in path. (#6) * Update git_helper.py * Update git_helper.py * Update git_helper.py * Make borgs not RR (#84) * Cargo integration tests update (#18) * Updated Cargo Integration Tests * usings * revert NoCargoOrderArbitrage * unneeded ; * . * review requests * review requests v2 * Move server_fans.ogg to a SoundCollection (#82) * quieter server fans * Restore individual parameter fields * Document Client, Server, and Shared files in folders starting with "K". Except microwaves. (#91) * document the entire owl * Apply suggestions from code review Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> * Can cancel orders from the console you placed it on (#11) * Make `InteractionTest` inherit from `GameTest` (#90) * Make InteractionTest inherit from GameTest * Convert MousetrapTest to use some GameTest features * Document stubbed Setup method * LoadTestMap now sets TestMap like CreateTestMap * Maybe fix? * Oh, derp * Fix approval section on order labels always being "Self" (#15) * Fixed label bug * review request * Add FixturesComponent to BaseWallmount (#81) * BUI template (#57) * Remove tasers from security locker fills (#67) * Ambient Music fixes and tweaks (#28) * reorganize yml * medical and engineering marker components and mass marking * bed * increase cooldown * did i leave that in * Renames all EntitySystem "ProtoMan" instances (#100) * Remove "ProtoMan" instances * guess we're caching gases now * Microoptimize Vector2i.Offset (#103) * microopt offset works on my machine award * tweaks * Fix event horizons using negative radius (#105) Not even valid why is it NEGATIVE just use ZERO! * Fix ItemGridPiece using invalid sprite bounds (#102) It inverted bottom and top. * Atmos category in the construction menu (#94) * commit * move on over --------- Co-authored-by: iaada <iaada@users.noreply.github.com> * Space Law Revision (#1) * Update SpaceLaw.xml * Update SLCrimeList.xml * Update SpaceLaw.xml to reflect AJCM-git's suggestion. * fixed (#128) * Directional arrow (#118) * arrow * yoink orginal arrow rsi * done * fixes * i just learnd about ignored components * Update Content.Client/DirectionalArrowIndicator/DirectionalArrowIndicatorComponent.cs Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com> * customArrows * docs * more docs * teg and blue arrow * misc * fixes * remove color * imma dummy * meta * soon to obsolete * class not partial --------- Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com> * Update RT to 277.2.0 (#138) * Refactor RecipeManager to use LINQ and PrototypesReloaded (#49) * small refactor RecipeManager and fix prototype reloading * wait... why is that here? * maybe? * Add section to link to space-wizards PR URL to PR template (#143) * Construction menu recipe history (#8) * Bugfix: Fix DrawDepth subfloor gap width, add gap for mapping subfloor layers (#70) * Hide artifact effects from spawnmenu (#149) * [FIX] Make slices of food fill out the space where the whole food used to be instead of dropping onto the floor (#160) * Add NU1900 to WarningsNotAsErrors (#171) * Removed duplicate function from solutions refactor in pricing system (#164) * Hide virtual items in cryoUI (#175) Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com> * Add Integration test for ExpireIdCardComponent (#162) Co-authored-by: Josh Greenslade <joshua.greenslade@onyxinsight.com> Co-authored-by: SlamBamActionman <slambamactionman@gmail.com> * Remove Staff of Entrance from Magic Event Spell (#114) * fix atmosphere system protoman * Revert "Update README.md with new links. (#2)" This reverts commit dffabf7. * Revert "Switch RT submodule to new repo (#19)" This reverts commit 1000a7b. * Revert "Add section to link to space-wizards PR URL to PR template (#143)" This reverts commit 48201fc. --------- Co-authored-by: Rem <GitRem@grifton.lol> Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> Co-authored-by: riccardi48 <39341154+riccardi48@users.noreply.github.com> Co-authored-by: Tayrtahn <tayrtahn@gmail.com> Co-authored-by: Jessica M <jessica@jessicamaybe.com> Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> Co-authored-by: Minerva <218184747+mnva0@users.noreply.github.com> Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com> Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: Kyle Tyo <akikai297@gmail.com> Co-authored-by: Connor Huffine <chuffine@gmail.com> Co-authored-by: portfiend <109661617+portfiend@users.noreply.github.com> Co-authored-by: rumaks <me@rumaks.xyz> Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com> Co-authored-by: āda <ss.adasts@gmail.com> Co-authored-by: iaada <iaada@users.noreply.github.com> Co-authored-by: ThatGuyUSA <thatguyusa123@gmail.com> Co-authored-by: InsoPL <lukasz.lindert@protonmail.com> Co-authored-by: AndrewFenriz <78079974+AndrewFenriz@users.noreply.github.com> Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com> Co-authored-by: Vladislav Suchkov <20380250+murolem@users.noreply.github.com> Co-authored-by: korczoczek <danielkorczok@gmail.com> Co-authored-by: B_Kirill <153602297+B-Kirill@users.noreply.github.com> Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com> Co-authored-by: JoshGreenslade <joshgreenslade@gmail.com> Co-authored-by: Josh Greenslade <joshua.greenslade@onyxinsight.com> Co-authored-by: SlamBamActionman <slambamactionman@gmail.com> Co-authored-by: Rami <ramialanbagy@gmail.com>

sleepyyapril added 2 commits November 4, 2025 12:45

feat: player requests

e8f748c

fix: fixed only being able to offer once

b817dbe

github-actions Bot added size/M S: Needs Review S: Untriaged labels Nov 4, 2025

sleepyyapril and others added 7 commits November 4, 2025 12:49

chore: cleanup

23aad26

feat: move to shared, kill registry

6da9c89

fix: dirty

2f13df3

chore: use Entity<T> for API methods

66c39b2

feat: reset on updated in event

a1ad731

fix: error

2e880ba

Merge branch 'master' into offer-and-interactions

16f0365

portfiend requested changes Jan 11, 2026

View reviewed changes

portfiend and others added 2 commits January 21, 2026 15:29

Merge branch 'master' into offer-and-interactions

aaf71a1

Update PlayerRequestPrototype.cs

8095d26

sleepyyapril commented Feb 12, 2026

View reviewed changes

Comment thread Content.Shared/_DEN/PlayerRequest/Prototypes/PlayerRequestPrototype.cs Outdated

Comment thread Content.Shared/_DEN/PlayerRequest/Prototypes/PlayerRequestPrototype.cs Outdated

Comment thread Content.Shared/_DEN/PlayerRequest/Prototypes/PlayerRequestPrototype.cs Outdated

sleepyyapril commented Feb 12, 2026

View reviewed changes

Comment thread Content.Shared/_DEN/PlayerRequest/Prototypes/PlayerRequestPrototype.cs Outdated

Comment thread Content.Shared/_DEN/PlayerRequest/Prototypes/PlayerRequestPrototype.cs Outdated

Comment thread Content.Shared/_DEN/PlayerRequest/Prototypes/PlayerRequestPrototype.cs Outdated

sleepyyapril commented Feb 12, 2026

View reviewed changes

Comment thread Content.Shared/_DEN/PlayerRequest/Prototypes/PlayerRequestPrototype.cs Outdated

sleepyyapril commented Feb 12, 2026

View reviewed changes

Comment thread Content.Shared/_DEN/PlayerRequest/Prototypes/PlayerRequestPrototype.cs Outdated

sleepyyapril added 2 commits February 12, 2026 14:00

Apply suggestions from code review

3f59a4c

private

878a5ce

sleepyyapril requested a review from portfiend February 12, 2026 19:17

portfiend requested changes Feb 12, 2026

View reviewed changes

portfiend added 2 commits March 27, 2026 19:00

Merge branch 'master' into offer-and-interactions

298f388

Merge branch 'master' into offer-and-interactions

366821c

portfiend added the S: Unfinished THIS DOES NOT NEED REVIEWING YET label May 14, 2026

sleepyyapril marked this pull request as draft May 27, 2026 09:18

portfiend pushed a commit that referenced this pull request Aug 10, 2026

Cargo integration tests update (#18)

c3952d5

* Updated Cargo Integration Tests * usings * revert NoCargoOrderArbitrage * unneeded ; * . * review requests * review requests v2

Navigation Menu

Uh oh!

Player Requests - #18

Player Requests#18
sleepyyapril wants to merge 15 commits into
TheDenSS14:masterfrom
sleepyyapril:offer-and-interactions

sleepyyapril commented Nov 4, 2025 •

edited

Loading

Uh oh!

portfiend left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

portfiend left a comment

Uh oh!

sleepyyapril commented Feb 26, 2026

Uh oh!

MajorMoth commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sleepyyapril commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

portfiend left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

portfiend left a comment

Choose a reason for hiding this comment

Uh oh!

sleepyyapril commented Feb 26, 2026

Uh oh!

MajorMoth commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sleepyyapril commented Nov 4, 2025 •

edited

Loading