Repository navigation
Validate Godot frame timing, transparency and complete playback - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original smoke check compared a frame before and after a fixed delay, which could miss loop failures or report a healthy full loop as unchanged. Add a reusable Godot validator that checks texture dimensions, actual transparency, per-frame timing, frame advancement and a complete loop/end, with a nonzero exit on failure and a 30-second watchdog.
Validated a fresh import of examples/source/walk.zip with Godot 4.7.2: seven 128×128 frames, 2.83-second cycle, one loop and seven frame changes. Reviewed SpriteFrames/AnimatedSprite2D/Image API definitions in the supplied Godot 4.8-dev source. This does not claim a compiled or tested 4.8 runtime, Unity validation, or improved generated-art quality. No API calls or image-generation credits used.