CUT-4711-Nuspec-Path-Bug-Fix#677
Merged
Merged
Conversation
kmaranionjc
added
manual
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where incorrect Windows path separators caused erroneous directory structures in nuspec builds when transitioning from Linux.
- Updated the changelog with version 2.18.1 details and release notes describing the bug fix.
- Updated the JumpCloud documentation to reflect the new Help Version 2.18.1.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PowerShell/ModuleChangelog.md | Added changelog entries for version 2.18.1 with bug fix info. |
| PowerShell/JumpCloud Module/Docs/JumpCloud.md | Updated the Help Version from 2.18.0 to 2.18.1. |
Files not reviewed (2)
- PowerShell/Deploy/BuildNuspecFromPsd1.ps1: Language not supported
- PowerShell/JumpCloud Module/JumpCloud.psd1: Language not supported
jworkmanjc
approved these changes
Apr 25, 2025
tonybjc
approved these changes
Apr 25, 2025
tonybjc
left a comment
tonybjc
left a comment
There was a problem hiding this comment.
Just a swap of back/forward slashes, looks good. Approved.
kmaranionjc
temporarily deployed
to
PublishToPSGallery
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
What does this solve?
The latest release of our workflow runner, when transitioning from Linux to Windows for Nuspec builds, has introduced a bug. This bug results in an incorrect directory structure for the
Public,Private, anden-Usfolders, where extra path information is included ex.Private\Private\Associationinstead ofPrivate\Association. The problem is caused by the use of Linux-style forward slashes (/) instead of Windows-style backslashes (\) in the directory paths. Correcting these path separators resolves the issue.How should this be tested?
. /Users/YOURUSER/Documents/GitHub/support/PowerShell/Deploy/BuildNuspecFromPsd1.ps1Screenshots