Grading PR

[martypdx]

Nice project overall. Good grasp of fundamentals of async coding for web server.

• Nice technical write-up in the README with the application structure and execution flow description.

• Remove dead files and dead code (commented out). I dunno why most of your files had one or two blank lines at the start. Varying use of whitespace from file to file (e.g. between fields in schema definition). In future, strive for cleaner, more consistent code formatting.

• Don't 'use strict'; in node.js v6. Add this to .eslintrc to make it stop complaining:

    "parserOptions": {
      "sourceType": "module"
    },
  

  (Then add an .eslintrc in public that sets it to script - see PR)

• Great job on crafting API tests that matched actual workflows and use cases. Make sure tests are strong and test more than presence/absence of response.

• eslint issues are meant to help you fix and clean up your code. If you just disable every line that has a problem, that defeats the purpose.

• Problems with REST API's. Url's describe resources (nouns). Refinements are query parameters.

• Would have been much cleaner and easier if you had:

  • put communityId in the jwt payload
  • add timestamps: true to schema to auto-add createdon

• Many of the more complex data gets were hacky. Fine to get it working, but then improve, you had a lot of extra code that wasn't needed, often using the wrong tool for job.