Add Reflect modifier#50
Open
TheMarstonConnell wants to merge 2 commits intomainfrom
Open
Conversation
- New EntityHurtModifier that deals bonus damage with a chance - Supports leveling from 1-3 with increased damage ratios - Level 1: 30% chance to deal 50% weapon damage - Level 2: 45% chance to deal 75% weapon damage - Level 3: 60% chance to deal 100% weapon damage - Works with swords, axes, and pickaxes - Uses particle effects on hit - Registered in ModifierRegistry and added to HURTERS set Co-Authored-By: halios9000 <halios9000@users.noreply.github.com>
- Add missing compatible() method - Add missing writeDetailsToLore() method - Fix fromNBT() to use getString/getInt instead of non-existent getStringOr/getIntOr Co-Authored-By: halios9000 <halios9000@users.noreply.github.com>
Owner
Author
|
Fixed compilation errors:
Build should pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new EntityHurtModifier called 'Reflect' that deals bonus damage when striking enemies.
Features
Implementation Details
The Reflect modifier uses the EntityHurtModifier interface pattern and includes: