Module split - #6
Draft
TheMode wants to merge 7 commits into
Draft
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Un-seal MinecraftConstants (generator + autogenerated); TickUtils/Tick derive from ServerFlag - Registries.staticRegistries() holder; freeze/tag-invalidation hooks; compression-threshold holder; PACKET_POOL off MinecraftServer - Local loggers/rethrow in MojangCrypt, AsyncUtils, SignatureValidator, RegistryData - GraphConverter: CommandManager/Player params -> CommandSender/CommandParser - Light.getNeighbors -> LightingChunk; Heightmap.Type+encode -> new lib HeightmapType - Collision sweep core -> BlockCollisionCore (lib), CollisionUtils/BlockCollision delegate - Sidebar.NumberFormat -> standalone scoreboard.NumberFormat - PROTECTED_MODIFIERS canonical home -> AttributeInstance (LivingEntity alias kept) - EntityMeta decoupled from Entity via new MetaTarget interface (~173 files) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d types (stage 5) - BlockHandler split: new lib BlockDataHandler identity super-interface; Block.withHandler/handler re-typed; callback sites narrow via instanceof - Shape.intersectEntity(Point, Entity) -> intersectEntity(Point, Point, BoundingBox) - Potion.sendAdd/RemovePacket relocated into Entity; WorldBorder.inBounds(Entity) dropped - AttackRange reach reparameterized over (GameMode, boolean isPlayer) - BlockIterator Entity ctors dropped; RelativeVec Entity/sender overloads -> RelativeVecUtils (framework) - SignatureValidator.from(Player) removed, from(PlayerPublicKey) added - Conditions.playerOnly/consoleOnly -> new SenderConditions (framework) - ping.Status/ServerListPingType: online-sampling -> ServerListPingEvent, LAN port injection -> OpenToLAN - AdventurePacketConvertor: int-entityId overload in lib; Entity/emitter overloads -> PacketSendingUtils Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…entType; javadoc demotions - ArgumentType.Command/Entity/Entities/ItemStack/Component -> new ServerArgumentType (same package) - GraphImpl/GraphConverter use new Argument.dispatchesCommand()/commandShortcut() hooks instead of instanceof ArgumentCommand - legacy parser.CommandParser.findCommand takes Function<String,Command> instead of CommandDispatcher - SelectKnownPacksPacket reads MinecraftConstants directly; RegistryData -> BlockCollisionCore (now public @internal) - javadoc {@link} demotions across lib-destined files (Player/Instance/Batch/PlayerConnection/CommandManager) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- :lib — unopinionated protocol/data (1055 files): packets, NetworkBuffer, codecs, registries, tags, components, coordinates, block/item/entity data, command structs - :framework — opinionated runtime (384 files): MinecraftServer, ServerProcess, events, listeners, live Instance/Entity/Player/Inventory, scheduler, threads, monitoring - root — aggregate 'minestom' artifact: merged modular jar keeping module-info (module net.minestom.server), so JPMS consumers and demo/testing are unaffected - :lib and :framework are classpath jars (split packages forbid two named modules); package-info files with @NotNullByDefault duplicated into both - Packet un-sealed (cross-package sealing requires a named module) - ArgumentParser format identifiers for server-bound args registered by framework - blossom (Git.java.peb) moved to :framework with ServerProcessImpl, its consumer - Scratch demo moved to a :lib-only source set (demo/src/scratch), wired into check, proving lib closure; PROTOCOL_VERSION import repointed to MinecraftConstants - code-generators output to lib/src/autogenerated/java; publishing adds net.minestom:lib and net.minestom:framework; BREAKING_CHANGES.md documents the API Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…registration - MinecraftServer.updateProcess syncs PacketVanilla.compressionThreshold (default was 0 vs MinecraftServer's 256; a CachedPacket warmed between init() and start() framed uncompressed and desynced compressed clients) - ArgumentParser.generate lazily loads ServerArgumentType on unknown identifiers so format strings in static initializers (before MinecraftServer.init()) keep working; clearer error for :lib-only consumers - BREAKING_CHANGES: AsyncUtils fire-and-forget note, wording fixes - aggregate sourcesJar includes module resources Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Binary CompatibilityThis Pull Request has introduced binary incompatible changes compared to the What is Binary Compatibility? What should you do?
View offending signatures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.