EnManager v1 - #37
Conversation
…rent appear point.
… instead of the items directly.
…es/return types, and adding comments everywhere with what I learned/know.
Report for GLMP01_01 (9109d21 - 9691e7a)No changesReport for GLME01 (9109d21 - 9691e7a)📈 Matched code: 17.83% (+0.06%, +1200 bytes) ✅ 21 new matches
📈 31 improvements in unmatched items
...and 1 more improvements in unmatched items Report for GLMP01_00 (9109d21 - 9691e7a)No changesReport for GLMJ01 (9109d21 - 9691e7a)No changes |
| JGeometry::TVec3f* fn_800E5564(s32); | ||
| u32 fn_800E55AC(s32); | ||
| s32 fn_800E55F0(s32); // Gets _0 member from AppearSlot | ||
| void* fn_800E5600(s32); // Dynamicaly casts Player to MoveObj |
There was a problem hiding this comment.
could be something like playerObj
This reverts commit 3780e18.
|
please add decomp.me scratches to all non-matchings |
What about for ones where part of it is because I/we dont know what the datatype of something is yet, such as like fn_800E5564 or fn_800E55AC? I am also realizing i left those as fake matches, ill have to change that, but like those functions could get a decomp.me but does it make sense if noone can complete it right now anyways? Wouldnt that make sense to either a) get rid of the match for now entirely (in order words just delete the function in the cpp and leave it at 0%) or b) just leave it with as much as we know for now, decompile more, come back when we know more, then open a decomp.me when there is more to work off of (if it couldn't be matched)? Like several functions I left what i knew so far to save people some time, but maybe its better I just leave them at 0 until other progress is made on other files? I will wait for your thoughts on this |
Ideally you would do scratches for all nonmatchings, and revert fake matches like those intrepert casts |
|
can you fix the new merge conflicts? |
|
yes, will address your other comments and handle the merge conflicts later tonight after work :) |
|
Should be good to go now, let me know if anything else is pending! |
|
Done |
|
Moved it as a macro! |
2 participants
The long awaited V1
This was a long split where I just spent a lot of time trying to learn my way around and trying to start to make associations where I could. I am open to any and all suggestions here, but I left a lot of comments on things to explain a lot of why/what I was going for. There are several I still have issues with, namely anything to do with TVec3F seems to be weird in this class.
Also, I think _4 of EnManager might be the list of things possible to be spawned and _804 handles maybe spawning them/despawning them in? I wouldnt bet on that just maybe some inital observations.
If you dont like anything, open to any criticism. Before I made any decomp.me links, wanted you to check though things to see if I missed anything easy or anything else before I made those links. Similarly, I tried to make this v1 "small", so I left some things alone (without trying to touch too many other TUs), as well as leaving some stuff to be changed/focused on as a result of this PR I suppose.