Skip to content

Remove d3dx8d dependency from MinGW builds #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnsterID wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove d3dx8d dependency from MinGW builds #2176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca35889
feat(mingw): Add D3DX8 elimination compatibility layer
JohnsterID Mar 29, 2026
66ed24d
feat(cmake): Add D3DX elimination build infrastructure
JohnsterID Mar 29, 2026
faa2be4
feat(d3dx): Add precompiled shader infrastructure
JohnsterID Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ include(cmake/compilers.cmake)
# Debug symbol stripping for Release builds (MinGW)
include(cmake/debug_strip.cmake)

# D3DX dependency verification for NO_D3DX builds (MinGW)
include(cmake/no_d3dx_verify.cmake)

@bobtista bobtista Aug 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this include after mingw.cmake or remove the configure-time outer guard. The verification command should also fail when objdump itself fails instead of allowing the grep miss to print SUCCESS.
On a fresh configure, this file is evaluated before mingw.cmake declares MINGW_NO_D3DX. Its outer condition is therefore false, add_no_d3dx_verification() is never defined, and the later COMMAND guards silently skip verification. It only activates on a subsequent configure if the option is already cached


include(FetchContent)

# MinGW-w64 specific configuration
Expand Down
Loading
Loading