-
Notifications
You must be signed in to change notification settings - Fork 8
[Test] Add Step Boundary Range Assertion to Weekly Review Test Suite #70
Copy link
Copy link
Open
Labels
accessibilityAccessibility / a11y improvements (ARIA attributes, keyboard navigation, contrast)Accessibility / a11y improvements (ARIA attributes, keyboard navigation, contrast)area:coreCore domain logic, shared arithmetic helpers, security, and utility servicesCore domain logic, shared arithmetic helpers, security, and utility servicesbeginner friendlyAccessible task suitable for developers new to open sourceAccessible task suitable for developers new to open sourcebugConfirmed defect, malfunctioning behavior, or validation errorConfirmed defect, malfunctioning behavior, or validation errorcommunityCommunity-driven enhancement, UX feedback, or resource sharingCommunity-driven enhancement, UX feedback, or resource sharingcontributions-welcomeCommunity contributions are explicitly encouraged for this issueCommunity contributions are explicitly encouraged for this issuedifficulty:beginnerBeginner-friendly task with single-file scope and clear acceptance criteriaBeginner-friendly task with single-file scope and clear acceptance criteriadifficulty:easyStraightforward task requiring basic familiarity with React/TypeScriptStraightforward task requiring basic familiarity with React/TypeScriptenhancementSmall improvement, refinement, or feature expansionSmall improvement, refinement, or feature expansiongood first issueCurated, self-contained task suitable for first-time contributorsCurated, self-contained task suitable for first-time contributorshacktoberfestEligible high-quality task for open-source community eventsEligible high-quality task for open-source community eventshelp wantedMaintainer is actively welcoming community contributions on this issueMaintainer is actively welcoming community contributions on this issuetestingUnit tests, test matrix expansion, validation fixtures, and regression coverageUnit tests, test matrix expansion, validation fixtures, and regression coveragetime:<15mQuick fix, typo correction, or minor tweak (< 15 minutes)Quick fix, typo correction, or minor tweak (< 15 minutes)up-for-grabsUnassigned issue that is available for any contributorUnassigned issue that is available for any contributor
Description
Activity
Metadata
Metadata
Assignees
Labels
accessibilityAccessibility / a11y improvements (ARIA attributes, keyboard navigation, contrast)Accessibility / a11y improvements (ARIA attributes, keyboard navigation, contrast)area:coreCore domain logic, shared arithmetic helpers, security, and utility servicesCore domain logic, shared arithmetic helpers, security, and utility servicesbeginner friendlyAccessible task suitable for developers new to open sourceAccessible task suitable for developers new to open sourcebugConfirmed defect, malfunctioning behavior, or validation errorConfirmed defect, malfunctioning behavior, or validation errorcommunityCommunity-driven enhancement, UX feedback, or resource sharingCommunity-driven enhancement, UX feedback, or resource sharingcontributions-welcomeCommunity contributions are explicitly encouraged for this issueCommunity contributions are explicitly encouraged for this issuedifficulty:beginnerBeginner-friendly task with single-file scope and clear acceptance criteriaBeginner-friendly task with single-file scope and clear acceptance criteriadifficulty:easyStraightforward task requiring basic familiarity with React/TypeScriptStraightforward task requiring basic familiarity with React/TypeScriptenhancementSmall improvement, refinement, or feature expansionSmall improvement, refinement, or feature expansiongood first issueCurated, self-contained task suitable for first-time contributorsCurated, self-contained task suitable for first-time contributorshacktoberfestEligible high-quality task for open-source community eventsEligible high-quality task for open-source community eventshelp wantedMaintainer is actively welcoming community contributions on this issueMaintainer is actively welcoming community contributions on this issuetestingUnit tests, test matrix expansion, validation fixtures, and regression coverageUnit tests, test matrix expansion, validation fixtures, and regression coveragetime:<15mQuick fix, typo correction, or minor tweak (< 15 minutes)Quick fix, typo correction, or minor tweak (< 15 minutes)up-for-grabsUnassigned issue that is available for any contributorUnassigned issue that is available for any contributor
good first issue,testing,difficulty:beginner,area:coretests/weekly-review.test.tsWhy This Matters
The Weekly Review ritual progresses through 5 discrete steps (
1: Retrospective,2: Tasks Audit,3: Habit Scorecard,4: Goal Alignment,5: Strategic Commitments). Boundary tests ensure invalid step indices (< 1or> 5) are rejected cleanly.Current Behavior
tests/weekly-review.test.tsvalidates standard step advancement, but does not explicitly assert that step indices 0 or 6 throw validation errors.Requested Change
Add a dedicated test block in
tests/weekly-review.test.tsasserting that step transitions clamp to valid range[1, 5].Acceptance Criteria
tests/weekly-review.test.ts.Verification
Contributor Notes
Self-contained unit test addition.