Remove one-step transfer_admin footgun in governance-core - #861
Merged
gboigwe merged 1 commit intoAug 29, 2026
Merged
Conversation
transfer_admin changed DataKey::Admin directly with no confirmation step, unlike the safe propose_admin/accept_admin two-step flow already used in this same contract. A typo'd address would permanently and irrecoverably lose admin control. Removed in favor of the existing two-step flow rather than trying to make a second admin-rotation path safe. Closes ThinkLikeAFounder#835
|
@ANTIDOT20 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
governance-core had both the safe two-step
propose_admin/accept_adminpattern and a one-steptransfer_adminthat wroteDataKey::Admindirectly with no confirmation. Removedtransfer_adminper the issue's own suggested approach, since the safe two-step flow already exists and there's no need for two admin-rotation paths.Issue
Closes #835
Test plan
transfer_adminincontracts/governance-core/