Add missing event emissions across governance-core, kyc-registry, liquidity-pool, multisig-treasury - #862
Closed
adenikeakan wants to merge 1 commit into
Closed
Conversation
…, liquidity-pool, multisig-treasury - governance-core: revoke_role and update_params now emit events, matching grant_role's existing pattern - kyc-registry: revoke_kyc now emits an event, matching submit_kyc/verify_kyc's existing pattern - liquidity-pool: withdraw, borrow, and accrue_interest now emit events, matching deposit/repay's existing pattern - multisig-treasury: approve_transaction and reject_transaction now emit events with signer and tx id; set_paused's existing event now also includes the admin who changed it Closes ThinkLikeAFounder#836 Closes ThinkLikeAFounder#837 Closes ThinkLikeAFounder#838 Closes ThinkLikeAFounder#839
Contributor
Author
|
Closing and re-raising now that the issues have been assigned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revoke_roleandupdate_paramsnow emit events, matchinggrant_role's existing pattern (governance-core: zero events emitted anywhere in the entire crate #836)revoke_kycnow emits an event, matchingsubmit_kyc/verify_kyc(kyc-registry: verify_kyc and revoke_kyc — the two most compliance-critical transitions — emit no events #837)withdraw,borrow, andaccrue_interestnow emit events, matchingdeposit/repay(liquidity-pool: withdraw, borrow, and accrue_interest emit no events (only deposit/repay do) #838)approve_transactionandreject_transactionnow emit events with signer + tx id;set_paused's existing event now also includes the admin who changed it (multisig-treasury: approve_transaction, reject_transaction, and set_paused emit no events #839)Issues
Closes #836
Closes #837
Closes #838
Closes #839