Dock composer notices and replace Send anyway with a real recheck - #118
Merged
Conversation
Implements the approved onboarding mockup (docs/design/onboarding-setup-card.html, sections 2 and 3): - All top-of-chat banners (provider status, turn errors, held sends, version skew, environment trouble, slow startup) collapse into a single slim notice row docked to the top of the composer: severity dot, one line, inline actions, worst notice first, the rest behind an "N more" expander; info-level notices wait while anything urgent is active - "Send anyway" is gone. "I've signed in" re-probes the provider over the refresh RPC, folds the snapshot into app state, and sends the held message through the normal gate when the answer agrees; otherwise the notice says "Still signed out." - The never-paired phone screen drops the download button for a three-step pairing guide (install on your computer, Settings > Devices > Add device, scan the QR); desktop widths keep the download action - The mockup file itself is included as the design reference
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
…blem Cold-boot screenshot verification caught the dock front-running the wrong row: with Codex signed out, the error-severity "Codex provider status" notice outranked the amber held-send notice, hiding the Sign in and I've signed in actions behind the expander. While a held-send notice is active for an instance, its provider-status row states the identical fact with none of the actions, so it now stays hidden (same suppression pattern the session startup notice uses).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements sections 2 and 3 of the approved onboarding mockup (
docs/design/onboarding-setup-card.html, included in this PR as the design reference). Section 1 (the first-run setup card) lands separately on top of these primitives.What changed
ComposerNoticeDock): severity dot, bold lead + truncating detail, inline actions, dismiss. Only the worst notice is visible; the rest expand behind "N more ▾". Info-level notices (version skew, update available) wait while anything urgent is active.selectComposerNoticesowns the ordering and is unit-tested.skipProviderPreflightbypass is deleted. A wrong guess shows "Still signed out. The terminal shows where the sign-in stopped."providerStatusNotice,threadErrorNotice,providerReadinessNotice,sessionStartupNotice);ComposerBannerStackandCompactStatusNoticeRowremoved.Notable during build
[contain:inline-size].Testing
vp fmt,vp lint,vp run typecheckgreen.composerNotices.test.tsordering/suppression cases).