Skip to content

Stabilize Windows terminal and pull request sidebar indicators - #148

Merged
badcuban merged 2 commits into
mainfrom
threadlines/fix-windows-terminal-icon
Aug 12, 2026
Merged

Stabilize Windows terminal and pull request sidebar indicators#148
badcuban merged 2 commits into
mainfrom
threadlines/fix-windows-terminal-icon

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

Summary

  • correlate PowerShell command-completion markers with the command generation that produced them
  • keep the terminal-running sidebar indicator from being cleared by a stale queued prompt marker on Windows
  • preserve the last-known pull request status during transient source-control provider lookup failures
  • clear retained pull request status only after a successful empty lookup, without carrying it across branch changes

Root cause

PowerShell can emit an OSC 633 completion marker before a newly submitted command while the terminal event drain is still processing queued output. The marker was previously applied to whichever command was current when it was drained, so the terminal icon could flash and disappear.

Pull request lookup errors were also collapsed into pr: null, making a transient GitHub/GitLab failure indistinguishable from a successful “no pull request” result and allowing an existing sidebar icon to disappear.

Impact

Windows terminal activity remains visible for the actual command lifetime, and pull request indicators remain stable through temporary provider failures on every platform.

Validation

  • vp fmt
  • vp lint (passes with existing repository warnings)
  • vp run typecheck
  • vp run '@threadlines/server#test' GitManager — 64 tests
  • vp run '@threadlines/server#test' Manager — 108 tests
  • vp run '@threadlines/server#test' VcsStatusBroadcaster — 13 tests

No web browser suite was required because the changes are server-only.

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
threadlines Skipped Skipped Aug 12, 2026 5:55am

Request Review

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Aug 12, 2026
@badcuban
badcuban marked this pull request as ready for review August 12, 2026 06:04
@badcuban
badcuban merged commit d8d6cbf into main Aug 12, 2026
20 checks passed
@badcuban
badcuban deleted the threadlines/fix-windows-terminal-icon branch August 12, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant