Stabilize Windows terminal and pull request sidebar indicators - #148
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PowerShell can emit an OSC 633 completion marker before a newly submitted command while the terminal event drain is still processing queued output. The marker was previously applied to whichever command was current when it was drained, so the terminal icon could flash and disappear.
Pull request lookup errors were also collapsed into
pr: null, making a transient GitHub/GitLab failure indistinguishable from a successful “no pull request” result and allowing an existing sidebar icon to disappear.Impact
Windows terminal activity remains visible for the actual command lifetime, and pull request indicators remain stable through temporary provider failures on every platform.
Validation
vp fmtvp lint(passes with existing repository warnings)vp run typecheckvp run '@threadlines/server#test' GitManager— 64 testsvp run '@threadlines/server#test' Manager— 108 testsvp run '@threadlines/server#test' VcsStatusBroadcaster— 13 testsNo web browser suite was required because the changes are server-only.