Skip to content

Run staged install before Electron packaging - #151

Merged
badcuban merged 1 commit into
mainfrom
fix/electron-packaging-retry-order
Aug 12, 2026
Merged

Run staged install before Electron packaging#151
badcuban merged 1 commit into
mainfrom
fix/electron-packaging-retry-order

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

What changed

  • restore the staged production dependency install before electron-builder runs
  • move the bounded transient-network retry to the electron-builder packaging command it was intended to wrap
  • add executable coverage proving transient packaging failures retry three times and non-network failures execute once

Root cause

PR #150 captured the adjacent staged-install Effect instead of the later packaging Effect. Because Effects are lazy, that deferred the install until after packaging. Nightly run 31647747869 exposed the ordering bug when Windows correctly reported that @anthropic-ai/claude-agent-sdk was missing from the stage. Linux and macOS completed, and workflow cleanup removed the failed draft release.

Validation

  • vp fmt
  • vp lint
  • vp run typecheck
  • vp run @threadlines/scripts#test (124 tests)
  • vp run release:smoke
  • focused desktop build test (26 tests)

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
threadlines Skipped Skipped Aug 12, 2026 10:48pm

Request Review

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Aug 12, 2026
@badcuban
badcuban marked this pull request as ready for review August 12, 2026 22:58
@badcuban
badcuban merged commit d5f8419 into main Aug 12, 2026
13 checks passed
@badcuban
badcuban deleted the fix/electron-packaging-retry-order branch August 12, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant