Preserve native subagent model omissions - #155
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
badcuban
added a commit
that referenced
this pull request
Aug 14, 2026
Two fixes for the inline subagent activity bar in the conversation: Flicker: a running agent's streamed commentary is a timeline entry that renders nothing, but its timestamp moves with every update. It could split and re-merge the turn's work groups as the agent streamed, and the live group never rendered the activity receipt, so the tracker blinked in and out mid-turn. Live commentary entries now stay out of grouping entirely, and a live work group that owns the turn's tracker renders the receipt above its spine so the bar survives group churn. Missing model/effort: the durable roster seeds a record for every agent before lifecycle rows fold in, so the "only inherit for a brand-new record" guard from #155 never fired and a collab spawn that stated no model lost the parent turn's dispatched selection. Native-spawn omission is now a sticky per-record fact instead: native subAgentActivity spawns still never inherit, while collab and Task spawns inherit the turn's model and effort even when the roster seeded their record first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waititem from retroactively applying the parent turn's settings to an already-known childRoot cause
Native
subAgentActivityspawn rows intentionally leave model and effort unknown. The first spawn record respected that, but a laterwaitrow reused the parent turn's model selection as a fallback becausenullwas treated as missing rather than as the established child value.Validation
vp exec vp run '@threadlines/web#test' session-logic(141 passed)vp fmtvp lintvp run typecheckgit diff --checkThis repairs the two failures currently shared by
mainand feature PR CI.