feat(web): skills join the composer / menu and commands read as pills - #169
Merged
Merged
Conversation
Typing / in a Codex thread now lists workspace skills in their own menu section; picking one inserts the same $skill token as the $ shortcut. Recognized leading commands (built-ins plus the provider's own) render as an editable pill instead of a bare color tint. Skill chips turn amber with an explanatory tooltip when the selected provider cannot resolve them, instead of silently sending literal text. Menu sections are now labeled by provider, split out plugin skills, and stay visible while filtering, with keyboard order matching the visible section order.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skills were only reachable through the Codex-native
$trigger, recognized slash commands got a bare color tint instead of the chip treatment other tokens get, and a$skillchip kept looking healthy after switching the thread to a provider that can't resolve it — the token was then sent as literal words./menu now lists Codex workspace skills in a labeled Skills section; selecting one inserts the same$skillchip as the$trigger, and Codex still receives the structured skill turn input./plugin:skill) render as a pill. Still an editableTextNodeserializing as plain text — CSS and recognized-set change only.ComposerSkillAvailability); when the selected provider's skill list is authoritative and missing the name, the chip turns amber with an explanatory tooltip. No warning flash while Codex's list is loading, no change to the send path.:-namespaced) get their own section, and headings stay visible while filtering. The flat keyboard-navigation order is partitioned with the same predicate as the section split, fixing a latent highlight-jump for namespaced commands.Gates:
vp fmt,vp lint,vp run typecheck, web unit tests, and the web browser suite (476 tests) all green. New browser tests cover namespaced-command recognition (prompt stays plain text) and the stale-chip transition. Pill, chips, and menu grouping were pixel-reviewed in dark and light mode.