fix(desktop): startup crash reports capture stdout too, not just stderr - #176
Merged
Merged
Conversation
The first field reports of desktop.backend.startup_failed arrived with an empty stderr tail: the server is an Effect app whose logger reports fatal causes on stdout, so stderr-only capture missed the one thing the report exists to carry. The per-run tail now interleaves both streams (capped as before) and the event property is renamed stderrTail -> outputTail.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first two field reports of
desktop.backend.startup_failed(v0.3.5, the Swedish user's machine) arrived with an empty stderr tail. The server is an Effect app whose logger reports fatal causes on stdout, so the stderr-only capture missed exactly the output the report exists to carry.Fix
The per-run tail in DesktopBackendManager now interleaves stdout and stderr (same 8 KiB cap, same scrubbing and redaction before send), and the event property is renamed
stderrTail→outputTail. The manager test now puts the fatal line on stdout, mirroring the real server.