Skip to content

fix(build): resolve workspace test runner consistently - #184

Merged
badcuban merged 1 commit into
mainfrom
fix/vite-plus-workspace-test-runner
Aug 24, 2026
Merged

badcuban merged 1 commit into
mainfrom
fix/vite-plus-workspace-test-runner

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

On Windows, workspace test scripts could resolve the global Vite+ binary instead of the repository-pinned binary and fail during test collection with Cannot read properties of undefined (reading config).

Route every workspace test entry point, including the browser-test task, through vp exec vp. This follows the command pattern already used by CI, stays cross-platform, and does not require a lockfile change.

Verification:

  • reproduced the direct vp test run collection failure on Windows
  • representative workspace test passed through the changed task path
  • formatting, lint, and diff checks passed
  • independent production review: APPROVE

@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadlines Ready Ready Preview Aug 24, 2026 7:08pm

Request Review

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Aug 24, 2026
@badcuban
badcuban force-pushed the fix/vite-plus-workspace-test-runner branch from e72c1f4 to 3a48c0a Compare August 24, 2026 19:08
@badcuban
badcuban merged commit 01edbf5 into main Aug 24, 2026
15 checks passed
@badcuban
badcuban deleted the fix/vite-plus-workspace-test-runner branch August 24, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant