Skip to content

fix(web): approved auto reviews no longer look like warnings - #194

Merged
badcuban merged 1 commit into
mainfrom
fix/auto-review-visibility
Aug 28, 2026
Merged

fix(web): approved auto reviews no longer look like warnings#194
badcuban merged 1 commit into
mainfrom
fix/auto-review-visibility

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

Approved automatic reviews were shown as orange runtime warnings because Codex sends both a guardian notice and a structured result.

This carries the structured outcome through the contract and projection, replaces only approved duplicate warnings with a quiet status row, and keeps denied, timed-out, aborted, and circuit-breaker warnings visible.

Tests:

  • vp fmt
  • vp lint
  • vp run typecheck
  • focused server, contracts, and web unit tests
  • vp run --cache '@threadlines/web#test:browser' (45 files, 496 tests)

Codex emits a warning notice alongside its structured automatic approval result, which made successful reviews look unsafe. Preserve the structured outcome, replace only approved duplicate warnings with a quiet status row, and keep denied or interrupted reviews visible.
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
threadlines Skipped Skipped Aug 28, 2026 3:53pm

Request Review

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Aug 28, 2026
@badcuban
badcuban merged commit f0730d2 into main Aug 28, 2026
16 checks passed
@badcuban
badcuban deleted the fix/auto-review-visibility branch August 28, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant