fix(web): panel button keeps its counts until the tab that shows them is open - #207
Merged
Merged
Conversation
… is open The header's panel button only showed the working-tree diffstat, the behind-remote count and the live-agent node while the whole sidebar was hidden. Opening the sidebar on the Agents tab alone dropped the diffstat even though no Source tab was on screen, and the same in reverse. The button now reads the sidebar's tab strip. The Source counts stay until a Source tab is in the strip, and the live node stays until an Agents tab is, since that tab draws its own.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
size:M
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top-right panel button only showed the working-tree +/- counts, the behind-remote arrow and the live-agent dot while the whole sidebar was hidden. Opening the sidebar on the Agents tab alone dropped the +/- even though no Source tab was on screen, and the same in reverse.
The button now reads the sidebar's tab strip. The Source counts stay until a Source tab is in the strip, and the live-agent dot stays until an Agents tab is, since that tab draws its own dot. A tab in the strip counts as open even when another tab is in front.
Covered by the ChatHeader render tests; ChatView browser suite, web typecheck, lint and fmt are green.