feat(web): task list in the activity popover sits on a spine - #213
Merged
Conversation
The task rows in the header activity popover were filled grey, blue, and green boxes with struck-through text, which reads badly on phone and desktop and fights the flat design rule. Render the steps as rows on the shared thread spine instead: a quiet dot for done steps, the pulsing accent tick for the current one with the line warming toward it, and a faint hollow ring for steps not started. The Done/Now/Next column is gone (kept for screen readers) and completed text is dimmed, not struck through. SpineNode moves from MessagesTimeline into ui/threadline so both surfaces share one dot.
When the model mis-closes the subject parameter of a TaskCreate call (`</subject>` instead of `</parameter>`), Claude Code's lenient parser folds the description and activeForm into the subject, so the plan step in the activity popover showed the whole tool call. Strip a stray closing tag that is followed by another parameter or the end of the string wherever a task subject is read: create, update, TaskCreate and TaskList results, and the activity feed labels.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task rows in the header activity popover were filled grey, blue, and green boxes with struck-through text. It looked bad on phone and desktop and fought the flat design rule.
The steps now sit on the shared thread spine: a quiet dot for done steps, the pulsing accent tick for the current one with the line warming toward it, and a faint hollow ring for steps not started. The Done/Now/Next column is gone (kept for screen readers) and completed text is dimmed instead of struck through. The spine dot moves into
ui/threadlineso the chat feed and this list share it.Second commit: task titles could carry a leaked tool-call tail (
</subject><parameter name="description">...) when the model mis-closes the subject tag and Claude Code's parser folds the next parameters into it. The adapter now strips that tail wherever it reads a task subject, so the plan step and activity feed label stay clean.Verified with fmt, lint, typecheck, the Claude adapter tests, and the popover browser tests. Screenshots checked in dark, light, and at phone width.