fix(desktop): threads waiting on background agents stay active in the taskbar badge - #215
Merged
Merged
Conversation
… taskbar badge A thread whose turn settled while its subagents were still running showed "waiting" in the sidebar but dropped out of the taskbar badge, quit warning, and update warning, which all counted only sessions with a running turn. Share one rule, isWaitingOnBackgroundTasks, between the sidebar pill, the chat view, and the running-thread selector so every surface treats a thread with pending background tasks as live work. The desktop status menu gets a "waiting" thread state so its tooltip stays truthful.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A thread whose turn settled while its subagents were still running showed "waiting" in the sidebar but dropped out of the taskbar badge, the quit warning, and the update warning. Those surfaces only counted sessions with a running turn, so a thread waiting on background agents read as finished.
The fix shares one rule,
isWaitingOnBackgroundTasks, between the sidebar pill, the chat view, and the running-thread selector. Every surface now treats a thread with pending background tasks as live work. The desktop status menu gets awaitingthread state so its tooltip stays truthful. One store test covers the selector.