fix(web): pull requests listed by two environments show as one row - #218
Merged
Merged
Conversation
Two connected environments pointed at the same remote each list the same pull request, and the page concatenated the listings, so every row and the sidebar's needs-you count doubled. Rows are now identified by host, repository and number. The merge keeps one row per pull request, seated with the first environment to list it (this device first), except that a listing whose project holds the repository takes over a row this device only found by searching the viewer's own work. Thread linking, the thread badge lookup and selection matching no longer require the same environment, so a thread on the other computer still claims the row, and the loaded-entries hook merges across environments too so the Project filter offers each project once.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this device is connected to another environment that points at the same remote, both list the same pull requests and the Pull Requests page showed each one twice. The sidebar's needs-you count doubled with it.
Rows are now identified by host, repository and number, and the merge keeps one row per pull request. The first environment to list it keeps the seat, and this device comes first, so a pull request is read and acted on from here whenever here can. The one exception is a row this device only found by searching the viewer's own work: a listing whose project actually holds the repository takes it over, since that row can check the branch out and knows its threads.
Thread linking, the thread badge lookup and selection matching no longer require the row's own environment, so a thread on the other computer still claims the row and a clicked row stays highlighted if the owning environment changes. The loaded-entries hook behind the Filters menu merges across environments the same way, so the Project filter offers each project once.