feat(web): the Merge button remembers the method last run on a repository - #222
Merged
Conversation
…tory The Merge button always ran the repository's first allowed method, so anyone who squashes had to open the arrow menu every time, while GitHub's own site remembers the last choice. The method a merge is confirmed with is now stored per repository on this computer and becomes the button's own while the repository still allows it. The button wears the method as one word (Merge, Squash, Rebase); the arrow menu and the confirm dialog keep the full names. Covered by a logic test and a browser test that merges, reopens, and finds the remembered method on the button.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Merge button always ran the repository's first allowed method, so anyone who squashes had to open the arrow menu every time, while GitHub's own site remembers the last choice.
The method a merge is confirmed with is now stored per repository on this computer and becomes the button's own while the repository still allows it. The button wears the method as one word (Merge, Squash, Rebase); the arrow menu and the confirm dialog keep the full names. Covered by a logic test and a browser test that merges, reopens, and finds the remembered method on the button.