fix(web): source control update toast stays up and shows progress - #237
Merged
Merged
Conversation
Clicking Update now on the git or GitHub CLI toast closed it immediately and waited in silence until the result toast arrived, while the Settings page only showed a spinner for updates started from its own button. The toast now stays open as the progress surface: it switches to a loading state, mirrors the server's job message (queued, running, checking) while the run is active, and finishes in place with the outcome. Closing it mid-run still reports the outcome as its own toast. The Windows job message now says the permission prompt may land in the taskbar, since elevation requested by the background server never comes to the front. Result wording is shared between the toast and Settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
badcuban
enabled auto-merge
September 6, 2026 06:09
badcuban
deleted the
threadlines/source-control-update-toast-progress
branch
September 6, 2026 06:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking Update now on the git or GitHub CLI toast closed it immediately and waited in silence until the result toast arrived. The Settings page only showed a spinner for updates started from its own button, so an update started from the toast looked like nothing was happening.
The toast now stays open as the progress surface. It switches to a loading state, mirrors the server's job message (queued, running, checking) while the run is active, and finishes in place with the outcome (success auto-hides, anything else keeps a Settings button). Closing it mid-run still reports the outcome as its own toast. The setup poll runs only while an update toast is up.
The Windows job message now tells the user the permission prompt may land in the taskbar and to click the flashing shield, since elevation requested by the background server process never comes to the front. Result wording is shared between the toast and Settings via one module.
Verified:
vp fmt,vp lint,vp run typecheck, server maintenance tests, the web unit tests for the touched modules, a new browser test that clicks Update now and checks the toast morphs and finishes in place, and the full web browser suite.