Skip to content

docs: PR rules leave small bundles to the developer and drop the checklist - #241

Merged
badcuban merged 1 commit into
mainfrom
threadlines/review-pull-request-instructions
Sep 6, 2026
Merged

docs: PR rules leave small bundles to the developer and drop the checklist#241
badcuban merged 1 commit into
mainfrom
threadlines/review-pull-request-instructions

Conversation

@badcuban

@badcuban badcuban commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Problem

The agent guide said every PR must hold exactly one concern, so an agent asked to ship a few small fixes together stopped and asked for permission instead. The PR template still carried the t3code-era header and a self-graded checklist, and the Open PR writer filled that checklist with unchecked boxes nobody clears.

Fix

AGENTS.md now says features and architecture changes get their own PR, and small fixes follow the developer's lead. The template is a Problem section, a Fix section, and a note asking for screenshots on UI changes, which matches the body shape AGENTS.md already asks for. CONTRIBUTING.md's test guidance now matches AGENTS.md as well: run the tests covering the change, and save the full suite for broad work.

…klist

The agent guide said every PR must hold exactly one concern, so an agent
asked to ship a few small fixes together stopped and asked instead. The PR
template still carried the t3code-era header and a self-graded checklist,
and the Open PR writer filled that checklist with boxes nobody ticks.

AGENTS.md now says features and architecture changes get their own PR, and
small fixes follow the developer's lead. The template is a Problem section,
a Fix section, and a note asking for screenshots on UI changes, matching the
body shape AGENTS.md already asks for. CONTRIBUTING.md's test guidance now
matches AGENTS.md too: run the tests covering the change, full suite for
broad work.
@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadlines Ready Ready Preview Sep 6, 2026 7:39am UTC

Request Review

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Sep 6, 2026
@badcuban
badcuban enabled auto-merge September 6, 2026 07:41
@badcuban
badcuban added this pull request to the merge queue Sep 6, 2026
Merged via the queue into main with commit f795df2 Sep 6, 2026
14 checks passed
@badcuban
badcuban deleted the threadlines/review-pull-request-instructions branch September 6, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant