fix(ci): release gate no longer fails when a merge cancels main's CI run - #251
Merged
Merged
Conversation
Dispatching a release while merges are landing failed at "Verify required CI checks passed". CI cancels the in-progress main run whenever the next merge lands, and the gate treated that cancelled run as the verdict for the release commit, even though the merge queue had already run the same checks on that exact commit and passed. The gate now ignores a cancelled run when the same check has a newer or older run with a real verdict on the commit. In-progress runs are still waited on, and a check whose only run was cancelled still fails.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
the
vouch:trusted
badcuban
enabled auto-merge
September 6, 2026 15:47
badcuban
disabled auto-merge
September 6, 2026 15:47
badcuban
enabled auto-merge
September 6, 2026 15:47
badcuban
disabled auto-merge
September 6, 2026 15:52
badcuban
enabled auto-merge
September 6, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dispatching a desktop release while merges are landing fails at "Verify required CI checks passed". CI cancels the in-progress main run whenever the next merge lands, and the gate treated that cancelled run as the verdict for the release commit. The merge queue had already run the same checks on that exact commit and passed, but the gate ignored that result. This is what broke the manual nightly on 2026-09-06 (run 34024003529): PR #248 merged two minutes after the release started and cancelled PR #250's main CI run.
Fix
scripts/verify-release-ci.tsnow treats a cancelled run as "no verdict" and falls through to the newest run of the same check that has one. In-progress runs are still waited on, and a check whose only run was cancelled still fails. The entry point is guarded withimport.meta.mainso the evaluator can be imported by tests; three focused tests cover the three cases. Running the fixed script against the failed commit passes.