fix(web): composer pull request row loads whole, closes, and follows the merge queue - #252
Merged
Merged
Conversation
…the merge queue Four things the docked row got wrong once it was in daily use. It drew in two beats: the number and chip first, then the project, branch and diff stat when the detail read landed seconds later. The listing behind the thread's own pull request already knows the branch and the size, and the project is the thread's own, so the row now draws whole from those and lets the detail sharpen them. It could not be closed. A close control hides the row for that pull request in that thread for the session; a thread moving on to another pull request gets the row back. "Merge when checks pass" took seconds to take a click, because the switch waited for the host to arm the merge and be re-read. It now flips on the click and rolls back only if the host refuses. Once GitHub takes a pull request into its merge queue it drops the auto-merge instruction, so the switch read as off while the chip said Queued, and flipping it re-armed and disarmed the queue entry. The popover now shows "In the merge queue" instead of the switch. The detail read also keeps polling while a pull request is armed with nothing in its way, so the chip sees the queue take it and the merge land instead of waiting on the slow listing.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
size:L
vouch:trusted
…n the line The chip in a transcript never showed the card the composer row shows, because the link component it renders through dropped every prop it did not know about, and the hover trigger's ref and pointer handlers were among them. The anchor's own props now ride through, so a trigger or tooltip wrapping a link reaches the element. The chip also drew the transcript link underline through itself and sat a pixel high, aligned to the baseline of its smaller text. It now aligns to the middle of the line and carries no underline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four things the docked pull request row got wrong once it was in daily use.
It drew in two beats. The number and chip appeared first, then the project, branch and diff stat when the detail read landed seconds later. The listing behind the thread's own pull request already knows the branch and the size, and the project is the thread's own, so the row now draws whole from those and lets the detail sharpen them when it lands.
ThreadPullRequestgainsheadBranchanddiffStatfor this.It could not be closed. A close control on the right hides the row for that pull request in that thread for the session. A thread moving on to another pull request gets the row back, and so does a restart.
"Merge when checks pass" took seconds to take a click, because the switch waited for the host to arm the merge and then be re-read. It now flips on the click (optimistic update on the shared detail query) and rolls back only if the host refuses.
Queued read as off. Once GitHub takes a pull request into its merge queue it drops the auto-merge instruction, so the switch read as unchecked while the chip said Queued, and flipping it re-armed and disarmed the queue entry. The popover now shows "In the merge queue" in place of the switch.
Polling.
shouldPollPullRequestDetailnow keeps the 20 s poll going while a pull request is armed and the host reports nothing in its way (mergeGatenotblocked), so the chip sees the queue take it and the merge land instead of waiting on the five-minute listing. This changes one existing expectation, which said an armed pull request under a queue was a settled state. Armed but blocked still does not poll.Verified: fmt, lint, typecheck; unit tests for
composerPullRequest.logic,pullRequests.logicandpullRequestReference; the ChatView browser test for the docked row, extended to cover closing it.