fix(web): sheet-mode panel puts its close button at the edge - #262
Merged
Conversation
At narrow widths the right panel opens as a sheet below the chat header, but its tab strip still reserved room for the Windows window-controls cluster and acted as a window drag region. The close button landed in the middle of the row and did not take clicks until the drag region was recomputed. The strip now takes an `overlay` flag from ChatRightPanel (present exactly when the sheet's dismiss handler is), and in that mode drops both the window-controls clearance and the drag region. The inline layout is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
badcuban
enabled auto-merge
September 9, 2026 19:55
badcuban
disabled auto-merge
September 9, 2026 19:59
badcuban
enabled auto-merge
September 9, 2026 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At narrow desktop widths the right panel opens as a sheet below the chat header. Its close button showed up in the middle of the header row and did not respond to clicks at first.
The tab strip always reserved space for the Windows window-controls cluster and always acted as a window drag region, which is right for the inline layout where the strip sits in the title bar. The sheet never shares that row. The strip now takes an
overlayflag, set byChatRightPanelwhenever the sheet's dismiss handler is present, and in that mode skips both the clearance and the drag region.No new test: a headless browser has no window-controls overlay, so a test could not tell the old code from the new. Strip browser tests, format, lint, and typecheck pass.