fix(web): the pull request row's wrap-up box is per thread and its Settings link works - #264
Merged
Merged
Conversation
…ttings link works The "Wrap up thread after merge or close" checkbox in the composer's pull request popup flipped the app-wide setting for every thread, and the grey "Settings" hint beside it was plain text that went nowhere. Each thread now keeps its own wrap-up choice in the local UI state store, falling back to the app setting until the box is clicked. The sidebar files a thread under Wrapped by that per-thread answer. The hint is a real link that jumps to the "Wrap up merged threads" row in general settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
badcuban
enabled auto-merge
September 9, 2026 20:38
github-actions
Bot
added
the
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Wrap up thread after merge or close" checkbox in the composer's pull request popup flipped the app-wide setting for every thread, and the grey "Settings" hint beside it was plain text that went nowhere.
Each thread now keeps its own wrap-up choice in the local UI state store, falling back to the app setting until the box is clicked. The sidebar files a thread under Wrapped by that per-thread answer, and the choice is dropped with the thread and survives a restart. The hint is a real link that jumps to the "Wrap up merged threads" row in general settings, which now carries an anchor id.
Note: the app-wide setting is a per-device client setting, so the per-thread choice is kept per device as well. Making it follow the thread across devices would need a server-side thread field like the auto-fix switch.
Gates:
vp fmt,vp lint,vp run typecheck, web unit tests foruiStateStore, and the web browser suite (52 files, 572 tests) all pass.