Follow-ups on the plugin pointer and program APIs from the #1116 and #1117 reviews.
- Grab guard duplicated.
pointer_hook makes the host side a single path, but the coordinator's float-grab guard exists once for on_click and again for on_context in src/coordinator/mouse.rs. Move it into one helper both presses call.
- Three-way choice untested.
apply_program decides live → send, absent with repo → start without keys, absent alone → report. Nothing tests that decision. Move it into a pure function beside admit_program, which programs.rs already tests without a multiplexer.
- Routing unpinned. Both
on_context tests use a single pane, so nothing proves a press reaches only the plugin that painted the node. Add a second pane with its own on_context.
- Test placement.
tests/mouse_context.rs sits apart from its on_click twins in tests/mouse.rs and is missing from the thurbox-testing skill's list. Move the tests, or list the file.
— LeTuR's agent
Follow-ups on the plugin pointer and program APIs from the #1116 and #1117 reviews.
pointer_hookmakes the host side a single path, but the coordinator's float-grab guard exists once foron_clickand again foron_contextinsrc/coordinator/mouse.rs. Move it into one helper both presses call.apply_programdecides live → send, absent withrepo→ start without keys, absent alone → report. Nothing tests that decision. Move it into a pure function besideadmit_program, whichprograms.rsalready tests without a multiplexer.on_contexttests use a single pane, so nothing proves a press reaches only the plugin that painted the node. Add a second pane with its ownon_context.tests/mouse_context.rssits apart from itson_clicktwins intests/mouse.rsand is missing from thethurbox-testingskill's list. Move the tests, or list the file.— LeTuR's agent