feat(enricher): fall back to translation when enrichment fails#84
Merged
Merged
Conversation
When AI enrichment raises or the JSON response can't be parsed, items were either dropped or left untranslated. Add a lightweight _translate_item fallback that translates the title and summary to Chinese so the item still appears in the digest. No new dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When content enrichment fails — either the AI call raises, or the JSON response can't be parsed — the item was previously dropped or left untranslated. This adds a lightweight translation fallback:
_translate_item()translates the title and summary to Simplified Chinese so the item still appears in the digest with a usable headline.Why
On a flaky API response or occasional malformed JSON, losing the item entirely (or showing untranslated English in a Chinese digest) is worse than a best-effort translation.
Changes
src/ai/enricher.py: add_translate_item(), and call it from the two existing failure paths (theexceptinenrich_batch, and theNoneparse result in_enrich_item).Notes