feat: add accepted state indicator and Done button to JsonDrawer#146
Merged
Conversation
- Adds a "Done" button at the bottom of the JSON panel to close it - Flashes a checkmark indicator whenever a typed edit is successfully parsed and applied to the draft - Empty blocks now render a blank textarea instead of "[]", and a blank/whitespace-only textarea is treated as an empty block list rather than a parse error
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
block-kitchen | 48d839a | Commit Preview URL Branch Preview URL |
Jul 07 2026, 06:32 PM |
- Done button now uses the shared primary Button component - The accepted checkmark now sits to the left of the copy button (top-right of the panel) and stays visible longer (1.8s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the JsonDrawer component with visual feedback when JSON input is accepted and added a "Done" button to close the drawer. The component now displays a checkmark indicator for 900ms after valid input is applied, and treats empty textarea input as an accepted empty block list rather than a parse error.
Why
Users need clear feedback that their JSON edits have been successfully applied. The previous implementation only showed validation errors, leaving successful submissions ambiguous. Additionally, a "Done" button provides an explicit way to close the drawer, improving UX clarity.
Test plan
pnpm typecheckpnpm lintpnpm testpnpm storybook(if UI changed)Manual verification: Confirm the checkmark indicator appears for 900ms after editing valid JSON, and that clearing the textarea to paste new content doesn't flash a parse error.
https://claude.ai/code/session_01FaHNdDWDDxR8j7psETAewZ