Skip to content

Bugfix: Filter keys with ':' when constructing metadata from io.grpc metadata. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimOrtel merged 26 commits into from
Feb 15, 2026
Merged

Bugfix: Filter keys with ':' when constructing metadata from io.grpc metadata. #126

Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5d1a2bf
Support export/local and default_symbol_visibility.
TimOrtel Dec 6, 2025
b50d92d
Support (pb.java).nest_in_file_class
TimOrtel Dec 6, 2025
ea726e3
Add option target validation tests. Closes #111
TimOrtel Dec 7, 2025
0db15c1
Add (unsupported) handling for option and public import.
TimOrtel Dec 7, 2025
8b2530b
Only write top level enums for common source set.
TimOrtel Dec 7, 2025
5add000
add support for closed enums.
TimOrtel Dec 21, 2025
b9d7ad2
Set packed option unavailable on proto editions.
TimOrtel Dec 21, 2025
0a8dcda
Fix enum scoping.
TimOrtel Dec 21, 2025
980b041
Breaking: Proto enums are now generated as sealed interfaces. Removed…
TimOrtel Dec 23, 2025
dc394aa
Add proto2 parsing
TimOrtel Dec 26, 2025
8c04983
Add proto2 grammar
TimOrtel Dec 26, 2025
02ae5c1
Add support for group serialization
TimOrtel Dec 26, 2025
8565b90
Use kotlin IllegalArgumentException.
TimOrtel Dec 26, 2025
8e7854e
Merge branch 'feature/editions_2024' into feature/proto2
TimOrtel Dec 26, 2025
d1e8939
Merge branch 'main' into feature/proto2
TimOrtel Dec 26, 2025
fd24733
Add descriptor.proto to well known types.
TimOrtel Jan 6, 2026
e467a11
Add proto options import support.
TimOrtel Jan 6, 2026
f453641
Support default option on enums.
TimOrtel Feb 7, 2026
14d0e6f
Add symlink
TimOrtel Feb 8, 2026
1f16aa8
Add required field parsing support.
TimOrtel Feb 14, 2026
dc4546e
Revert source command.
TimOrtel Feb 14, 2026
b845d9e
Fix some tests.
TimOrtel Feb 14, 2026
d6391e8
Fix group message reading.
TimOrtel Feb 15, 2026
f5d24b3
Update readme.
TimOrtel Feb 15, 2026
dd0f18b
Filter keys with ':' when constructing metadata from io.grpc metadata.
TimOrtel Feb 15, 2026
6240c5b
Merge branch 'main' into bugfix/fix_status_parsing
TimOrtel Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kmp-grpc-core/src/androidJvmCommon/kotlin/io/github/timortel/kmpgrpc/core/conversionutil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ internal val Metadata.jvmMetadata: JvmMetadata
internal val JvmMetadata.kmMetadata: Metadata
get() {
val entries: List<Entry<*>> = keys().mapNotNull { keyName ->
// https://github.com/grpc/grpc-java/issues/11873#issuecomment-2639132154
if (keyName.startsWith(':')) return@mapNotNull null

if (keyName.endsWith(BINARY_KEY_SUFFIX)) {
val key = io.grpc.Metadata.Key.of(keyName, JvmMetadata.BINARY_BYTE_MARSHALLER)

Expand Down