docs: add kotlin code for service docs#2421
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2418 by adding Kotlin equivalents to the Service documentation code examples, presented alongside existing Java snippets using tabbed AsciiDoc blocks.
Changes:
- Introduces
[tabs]sections to show Java and Kotlin examples side-by-side across Service docs pages. - Adds Kotlin example snippets for REST API setup/custom endpoints, modeling/enrichment, metrics, demo data, and constraint weight overrides.
- Updates multiple pages to ensure Kotlin coverage is available on all relevant Service documentation topics.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/src/modules/ROOT/pages/service/rest-api.adoc | Adds tabbed Java/Kotlin REST API examples (DTO/resource, converter, validator, custom endpoints). |
| docs/src/modules/ROOT/pages/service/modeling-changes.adoc | Adds tabbed Java/Kotlin examples for SolverModel and enrichment APIs. |
| docs/src/modules/ROOT/pages/service/exposing-metrics.adoc | Adds tabbed Java/Kotlin examples for input/output metrics and combined metrics support. |
| docs/src/modules/ROOT/pages/service/demo-data.adoc | Adds tabbed Java/Kotlin examples for implementing DemoDataGenerator. |
| docs/src/modules/ROOT/pages/service/constraint-weights.adoc | Adds tabbed Java/Kotlin examples for constraint references and mapping overrides into solver config. |
Contributor
|
On the |
greyhairredbear
approved these changes
Jun 25, 2026
greyhairredbear
left a comment
Contributor
There was a problem hiding this comment.
Just a few minor comments. Feel free to ignore all of them, if you think that might be going into a bit too much detail or not be required yet.
triceo
approved these changes
Jun 26, 2026
triceo
left a comment
Collaborator
There was a problem hiding this comment.
If Peter says the Kotlin bits are OK, I trust him.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves: #2418
Not all Service pages had the Kotlin equivalent code examples yet.
@greyhairredbear could you do some Kotlin checking? Its been a while for me.