perf: simplify how value ranges are built#2425
Merged
Merged
Conversation
triceo
commented
Jun 26, 2026
|
|
||
| // Solution related fields | ||
| private @Nullable ValueRangeItem<Solution_, Entity_, ValueRange<Value_>, Value_> fromSolutionItem; | ||
| private @Nullable Map<Value_, Integer> fromSolutionValueIndexMap; |
Collaborator
Author
There was a problem hiding this comment.
Was only returned by a method that was never called...
triceo
commented
Jun 26, 2026
| return null; | ||
| } | ||
|
|
||
| private Map<Value_, Integer> getIndexMapFromSolution() { |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves performance of reachable-values construction by avoiding redundant processing when multiple entities share the same (deduplicated) value range, and it adds test coverage to prevent regressions in that scenario.
Changes:
- Build reachable values by grouping entity indices per distinct
ValueRangeinstance and processing each range once. - Simplify sorter delegation in
getFromEntity(...)and tighten encapsulation ofHashedValueRange. - Add a regression test for shared entity value ranges; modernize test code to use
List.getFirst()(JDK 21).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/src/main/java/ai/timefold/solver/core/impl/score/director/ValueRangeState.java | Groups entities by deduplicated ValueRange instance to avoid repeated bitset work while still registering reachability per entity. |
| core/src/test/java/ai/timefold/solver/core/impl/heuristic/selector/common/ReachableValuesTest.java | Adds coverage ensuring entities sharing a value range are all registered as reachable, and co-values behave as expected. |
|
zepfred
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.