fix(tui): reset chord indicator on timeout + complete yank-mode hint - #20
Merged
Merged
Conversation
The yank chord (e.g. `yq` = yank query) only resolves if the second key is pressed within the 1s chord window. Two papercuts made this confusing: - The on-screen "Yank mode" hint omitted `v` and `q`, so it wasn't clear which key yanked the query. Now lists y/r=row, c=column, a=all, v=cell, q=query, ESC=cancel. - The chord timeout was only evaluated when the next key arrived, so a dangling chord (`y` with no follow-up) left the hint on screen forever, and a key pressed after the timeout left a stale indicator. Added KeyChordHandler::clear_if_timed_out(), called from the idle loop to cancel a lapsed chord and refresh, and clear the hint on the SingleKey path. The "Yank mode" hint now visibly resets ~1s after `y`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The yank chord (e.g.
yq= yank query) only resolves if the second key is pressed within the 1s chord window. Two papercuts made this confusing:The on-screen "Yank mode" hint omitted
vandq, so it wasn't clear which key yanked the query. Now lists y/r=row, c=column, a=all, v=cell, q=query, ESC=cancel.The chord timeout was only evaluated when the next key arrived, so a dangling chord (
ywith no follow-up) left the hint on screen forever, and a key pressed after the timeout left a stale indicator. Added KeyChordHandler::clear_if_timed_out(), called from the idle loop to cancel a lapsed chord and refresh, and clear the hint on the SingleKey path. The "Yank mode" hint now visibly resets ~1s aftery.