feat(readers): add READ_JSON table function and error on unknown tabl… - #22
Merged
Conversation
…e funcs READ_JSON reads a whole JSON document — a JSON array of objects (including pretty-printed multi-line arrays) or newline-delimited JSON — and emits one row per object. Accepts a file path or '-' for stdin, sharing the cached-once stdin buffer with the other readers. This is the multi-line counterpart to READ_JSONL, which requires exactly one object per line and so failed on pretty-printed arrays like data/production_vwap.json. The record->table builder is extracted from READ_JSONL into a shared json_records_to_table() helper so both functions produce identical, order-preserving, type-inferred output. Also fix a silent fall-through in the FROM-clause parser: an unrecognised name(...) used to degrade to the DUAL placeholder (the bogus DUMMY/X row), masking typos. It now errors with a pointer to --list-functions. Adds 7 unit tests for READ_JSON. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e funcs
READ_JSON reads a whole JSON document — a JSON array of objects (including pretty-printed multi-line arrays) or newline-delimited JSON — and emits one row per object. Accepts a file path or '-' for stdin, sharing the cached-once stdin buffer with the other readers. This is the multi-line counterpart to READ_JSONL, which requires exactly one object per line and so failed on pretty-printed arrays like data/production_vwap.json.
The record->table builder is extracted from READ_JSONL into a shared json_records_to_table() helper so both functions produce identical, order-preserving, type-inferred output.
Also fix a silent fall-through in the FROM-clause parser: an unrecognised name(...) used to degrade to the DUAL placeholder (the bogus DUMMY/X row), masking typos. It now errors with a pointer to --list-functions.
Adds 7 unit tests for READ_JSON.