Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=========================================
- Coverage 97.45% 97.2% -0.26%
=========================================
Files 25 25
Lines 2321 2358 +37
=========================================
+ Hits 2262 2292 +30
- Misses 59 66 +7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to just get a discussion going about a potential immediate-mode API. This API does not require the user to be concerned with
manual_pollorstart_polling, and instead does everything via thesendandrecvcalls (now called_immediatefor convenience of implementation).Regarding performance, we can configure whether to run resending, polling the underlying socket, handle idle clients as a function of the Nth
recv/send. Ideally we can run all this at every call to avoid any unexpected "why doesn't my packet arrive?" questions.