Fix #277 Add connections on inbound packets#278
Closed
ncallaway wants to merge 1 commit intoTimonPost:masterfrom
Closed
Fix #277 Add connections on inbound packets#278ncallaway wants to merge 1 commit intoTimonPost:masterfrom
ncallaway wants to merge 1 commit intoTimonPost:masterfrom
Conversation
Contributor
|
As I mentioned in #277 the main idea was to accept only by responding from the server. I think it is a security thing, as it allows server to select connections that it wants to accept, instead of someone else connecting without permission. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #277.
I've confirmed that the behavior of the heartbeat demo seems more stable after this change:
server
client
I'm somewhat wary of this change due to the comment from the original refactor (#258). I'd love to have @TimonPost or @fraillt give critical thought and feedback about whether this approach might cause any issues.