Skip to content

cosemessage: expect EOFError for protected header#12

Merged
TimothyClaeys merged 2 commits intoTimothyClaeys:masterfrom
setrofim:master
Oct 4, 2019
Merged

cosemessage: expect EOFError for protected header#12
TimothyClaeys merged 2 commits intoTimothyClaeys:masterfrom
setrofim:master

Conversation

@setrofim
Copy link
Contributor

cbor library differs in the exception raised when attempting to load an
empty string between its Python and C backends. When using the former
(e.g. on Windows), an EOFError rather than a ValueError is raised.

cbor library differs in the exception raised when attempting to load an
empty string between its Python and C backends. When using the former
(e.g. on Windows), an EOFError rather than a ValueError is raised.
Bump version for PyPI.
@setrofim
Copy link
Contributor Author

I have submitted a fix to align raised exceptions between the two implementations to cbor_py repo: brianolson/cbor_py#11. However, given that it looks like it hasn't been active in a while, it is still worth expecting both exceptions to be raised.

@TimothyClaeys TimothyClaeys merged commit a3062d4 into TimothyClaeys:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants