Skip to content
This repository was archived by the owner on Nov 21, 2021. It is now read-only.

Fix tabs/hide-tabs-windows.css on newer Firefox versions - #144

Open
craftycorvid wants to merge 1 commit into
Timvde:masterfrom
craftycorvid:master
Open

Fix tabs/hide-tabs-windows.css on newer Firefox versions#144
craftycorvid wants to merge 1 commit into
Timvde:masterfrom
craftycorvid:master

Conversation

@craftycorvid

Copy link
Copy Markdown
Contributor

No description provided.

@craftycorvid

Copy link
Copy Markdown
Contributor Author

Closes #143

@Qwerty-Space Qwerty-Space left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's too little space at the top, however it does work very nicely!
image
Notice how it cuts off the top of the icon?

@Timvde

Timvde commented Apr 9, 2019

Copy link
Copy Markdown
Owner

I didn't merge this at first because there was some discussion, but now I merged #145 without thinking about this open PR... Is that one good too?

@BurntFood

BurntFood commented Apr 13, 2019

Copy link
Copy Markdown

Tested #145 against this and it has an issue where I am seeing tab names/buttons behind the address bar. This one on the other hand works perfectly. It just needs personal tweaking of a few numbers for the problem @Qwerty-Space has.
In my case I just had to change margin-top: -28px; and margin-right: 110px;.

@Timvde

Timvde commented Apr 13, 2019

Copy link
Copy Markdown
Owner

Any chance those numbers can be generalized? Is this one still better with the wrong numbers? In that case, I'll revert the other one and merge this,

@Qwerty-Space

Copy link
Copy Markdown
Contributor

I think this one is fine tbh. I was just being a bit nitpicky. Most people probably won't notice.

I also don't have access to a Windows machine to test this on atm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants