Upgrade framework version 6lts#105
Open
sfsharapov wants to merge 4 commits into
Open
Conversation
- Added .NET 6 style region with the same code. .NET Core 3.1. will run out of support period soon and old style code could be removed; - Removed unused package reference .
Author
|
@rus-art, could you review the changes? |
Contributor
|
Спасибо за участие. Скоро выйдет новый sdk для новой версии Тинькофф Инвестиций, там будет взаимодействие с api на базе grpc. Текущий sdk скорее всего будет признан устаревшим. Так что пока не знаю, насколько есть смысл развивать его. |
Comment on lines
-1
to
+3
| using System.IO; | ||
| #if NETCOREAPP3_1 | ||
|
|
||
| using System.IO; |
There was a problem hiding this comment.
Бессмысленное изменение этого файла. Top level statements работают с C# 9 и не зависят от рантайма. Т. е. можно получить top-level statement хоть на древнем фреймворке 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to add targeting for .NET 6, which LTS version. I've prepared pull request for that. Also I've made other minor changes. Please review them, however I don't expecting that there would be a trouble.
Commit in Tests package are disputable. There are two different version of the same package for different versions of the framework.
--
Предлагаю добавить поддержку .NET 6 каркаса (фреймворка) для данного пакета.
Большинство изменений косметические. Изменения в проекте Тестов, требуют утверждения. Возможно стоит для разных версий фреймворка использовать последние версии пакетов. Просто я ещё не проверил на наличие ошибок в этом варианте.