Conversation
Contributor
|
I'm unsure if you want potential help with this, but splitting PoseEstimate into two records makes things much more manageable. Most things should be here with the needed logic. A few changes to what we have would be.
|
Contributor
Author
|
Idk how much time I'll have to actually finish this up, if you want to move your changes here it would definitely be much appreciated |
JacksonElia
reviewed
Feb 25, 2025
| this.avgTagArea = 0; | ||
| this.rawFiducials = new RawFiducial[] {}; | ||
| this.isMegaTag2 = false; | ||
| this(new Pose2d(), 0, 0, 0, 0, 0, 0, new RawFiducial[0], false); |
Member
There was a problem hiding this comment.
lol idk why i didnt do this
JacksonElia
reviewed
Feb 25, 2025
| * | ||
| * @return a PoseEstimate with default values | ||
| */ | ||
| public static PoseEstimate empty() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start implementing records into PoseEstimate and such