check for out of order ness#257
Open
Tmonster wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating the GlobalTableFunctionState for a multi file function, some extensions can reject filter pushdowns when
supports_pushdown_typeis called. This rejection appends the column to the projection_ids. In some cases projection_ids and column_ids will then be the exact same, but the columns will be out of order due to the rejection. Without honoring projection_ids in that case, output_chunk types follow projection_id ordering but the executor processes all// reader_data.expressions in column_ids order, causing type mismatches. DuckDB-Iceberg currently does this by rejecting filters on equality delete columns