feat: add hints to HDR-dependent settings and remove HDR toggle - #44
Merged
ToRvaLDz merged 2 commits intoAug 2, 2026
Merged
Conversation
Owner
|
Thank you for this, and for taking the time to work through both approaches, the write-up in each PR made the trade-off easy to follow. Sorry for the long delay in getting to it. Going with this one over #43: keeping the fields fully legible and explaining why they're inactive via the subtitle + tooltip is less intrusive than full dimming, and it lines up with your own reasoning about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Changes
1. Show "inactive" subtitle hint on HDR-dependent settings when CM isn't HDR-capable
Controls under the HDR/EDID Override group (SDR EOTF, luminance fields, etc.) as well as some other settings only affect the visual output when Color Management is set to
hdrorhdredid. When CM is set to any other value, these rows now show an"inactive"subtitle with a tooltip explaining the settings may not apply — while remaining fully modifiable. (Hyprland's auto HDR setting can still make them relevant.)_hdr_dependent_rowslist collecting relevant widgets_hdr_dependent_settings_hintssync method that sets subtitle + tooltip on each rowupdate_from_monitor) and on every property change (_on_changed2. Remove standalone HDR toggle
color_management = "hdr"already produces the same config output as the oldhdr: truetoggle. The standalone switch (_sw_hdr) was redundant with the Color Management dropdown and potentially confusing.hdr: boolfromMonitorConfigcm = self.color_management(removed the("hdr" if self.hdr else "")fallback in both legacy and Lua paths)Profile.from_dict: profiles with"hdr": trueand no explicit CM are auto-converted tocolor_management: "hdr"on load_sw_hdrwidget creation,set_active, andget_activeTests
Added
tests/test_hdr_migration.pycovering:hdr: truewithout CM →color_management: "hdr"hdr: truehdrkey → unchangedhdr: false→ unchangedhdrnot present in serialized outputThis was chosen as an alternative to the solution offered in #43 due to the presence of hyprland config like
cm_auto_hdrwhich automatically changes color management profile to hdr when in fullscreen application. Thus, full dimming felt to intrusive. Thus this offers an alternative solution to #43.